resolve rapid species home #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azangru
reviewed
Dec 9, 2024
app/api/resources/rapid_view.py
Outdated
| # Resolve species home | ||
| # https://rapid.ensembl.org/Homo_sapiens_GCA_009914755.4/ | ||
| # https://rapid.ensembl.org/Homo_sapiens_GCA_009914755.4/Info/Index | ||
| @router.get("/{species_url}/{subpath:path}", name="Rapid Species Home") |
There was a problem hiding this comment.
Isn't species_url properly referred to as species_url_name?
azangru
reviewed
Dec 9, 2024
app/api/resources/rapid_view.py
Outdated
| async def resolve_species(request: Request, species_url: str, subpath: str): | ||
| (species_name, accession_id) = species_url.split("_GCA_") | ||
| assembly_accession_id = "GCA_" + accession_id | ||
| genome_object = get_genome_id_from_accession(assembly_accession_id) |
There was a problem hiding this comment.
get_genome_id_from_accession from_assembly_accession_id?
azangru
reviewed
Dec 9, 2024
| genome_object = get_genome_id_from_accession(assembly_accession_id) | ||
| if genome_object: | ||
| genome_id = genome_object.get("genomeUuid") | ||
| url = f"{ENSEMBL_URL}/species/{genome_id}" |
There was a problem hiding this comment.
Do we get genome tag from the metadata api, by the way?
I suppose none of the species on rapid will have a genome tag; but still, what if?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to resolve rapid species home urls.
https://rapid.ensembl.org/Homo_sapiens_GCA_009914755.4/
https://rapid.ensembl.org/Homo_sapiens_GCA_009914755.4/Info/Index
Also it would redirect rapid home page to beta home - something to decide whether to do it or not.
Uses new grpc endpoint in web-metadata-api Ensembl/ensembl-web-metadata-api#63
https://www.ebi.ac.uk/panda/jira/browse/ENSWBSITES-2830